forked from leanprover/lean4
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : toInt_shiftLeft
theorem
#37
Draft
mhk119
wants to merge
13
commits into
master
Choose a base branch
from
toInt_shiftLeft
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `GetElem` lemmas for the basic `Vector` operations. The `Vector` API is still very sparse, but I'm hoping to infill rapidly.
This PR removes unnecessary parameters from the funcion induction principles. This is a breaking change; broken code can typically be adjusted simply by passing fewer parameters. Part 1, before stage0 update. Closes leanprover#6320
This PR removes unnecessary parameters from the funcion induction principles. This is a breaking change; broken code can typically be adjusted simply by passing fewer parameters. Part 2, adjusting after stage0 update. Closes leanprover#6320
This PR adds missing `(types := true)` to `#reduce` example in [Readers example](https://lean-lang.org/lean4/doc/monads/readers.lean.html). Since [4.10](https://lean-lang.org/blog/2024-8-1-lean-4100/) the `(types := true)` is necessary for the `ReaderM Environment String` type to be reduced into `Environment → String`.
…rover#6322) This PR removes the deprecated aliases `Int.div := Int.tdiv` and `Int.mod := Int.tmod`. Later we will rename `Int.ediv` to `Int.div` and `Int.emod` to `Int.mod`.
tobiasgrosser
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This seems self-contained. You can probably mention that this completes the toInt/Nat/Fin family for shiftLeft.
Might be worth to PR to lean proper.
This PRs continues cleaning up Array lemmas and improving alignment with List.
This PR lets `_` be used in numeric literals as a separator. For example, `1_000_000`, `0xff_ff` or `0b_10_11_01_00`. New lexical syntax: ```text numeral10 : [0-9]+ ("_"+ [0-9]+)* numeral2 : "0" [bB] ("_"* [0-1]+)+ numeral8 : "0" [oO] ("_"* [0-7]+)+ numeral16 : "0" [xX] ("_"* hex_char+)+ float : numeral10 "." numeral10? [eE[+-]numeral10] ``` Closes leanprover#6199
Further alignment of `Array` and `List` lemmas. Moved lemmas about `List.toArray` to a separate file, and aligned lemmas about membership.
Continuing cleanup of Array lemmas.
mhk119
force-pushed
the
toInt_shiftLeft
branch
2 times, most recently
from
December 9, 2024 17:45
01199ca
to
fe481dc
Compare
mhk119
force-pushed
the
toInt_shiftLeft
branch
from
December 9, 2024 19:20
fe481dc
to
335dc5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.